Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when PR is opened for 0.3/0.1 branch #2813

Closed
taiki-e opened this issue Dec 7, 2023 · 4 comments · Fixed by #2841
Closed

Warn when PR is opened for 0.3/0.1 branch #2813

taiki-e opened this issue Dec 7, 2023 · 4 comments · Fixed by #2841

Comments

@taiki-e
Copy link
Member

taiki-e commented Dec 7, 2023

This would help avoid problems like #2801 (comment).

rust-lang/rust already has a mechanism for this (rust-lang/rust#118607 (comment)), but I don't know how to enable it for this repo.

@edef1c
Copy link
Contributor

edef1c commented Feb 5, 2024

I think having explicit mention of it in CONTRIBUTING.md (or even any documentation about the branching/backporting policy at all) would be a good start. I explicitly looked for some, didn't find any, found that HEAD pointed at 0.4, and figured I should target my bugfix to the release branch.

In other words, it wasn't exactly an accident: it was my genuine best guess at how to get a bugfix merged into a previous release line in the absence of documentation, given that I was uncertain that a fix to master would get cherry-picked to a release branch.

@taiki-e taiki-e pinned this issue Mar 9, 2024
@taiki-e
Copy link
Member Author

taiki-e commented Mar 9, 2024

cc @Kobzol: Are there any options for doing this in rust-lang/team or somewhere?
I was going to refer to what rust-lang/rust does in rust-lang/team, but rust.toml doesn't seem to exist in the dierctry that futures-rs.toml exist, so I'm not sure what to do.

@Kobzol
Copy link

Kobzol commented Mar 9, 2024

Not in rust-lang/team, this is a functionality of rustbot/triagebot. Also, rust-lang/rust isn't managed by team, it will probably be the last repo to be added due to its complexity 😆

You need to configure this in the triagebot file.

@taiki-e
Copy link
Member Author

taiki-e commented Mar 9, 2024

You need to configure this in the triagebot file.

Thanks! I opened a PR to enable it.

@taiki-e taiki-e unpinned this issue Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants