-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BoxTryFuture
and BoxTryStream
aliases
#2869
Comments
It's quite popular I would say: https://github.com/search?q=BoxTryFuture&type=code |
Only 4 seem to be unique (tide, tinychain, txn_lock, tokio-tide, and tokio-tide's code is in comment). All the others seem to be forks of tide and tinychain. |
You're right. So you consider this extra for now? I still think that this is quite useful.
I can see that the usage of async fn get<'a>(&'a self) -> BoxStream<'a, Result<BoxFuture<'a, Result<T, Error>>, Error>> { to this: type ItemStream<'a, T, Err> = BoxTryStream<'a, BoxTryFuture<'a, T, Err>, Err>>;
async fn get<'a>(&'a self) -> ItemStream<'a, T, Error> { made my day :) |
BoxFuture
andTryFuture
are already in lib, but why notBoxTryFuture
? The same goes forBoxTryStream
andTryStream
. I'm declaring both of them quite often, maybe I'm not alone with this problem, so why not add them tofutures
after all?The text was updated successfully, but these errors were encountered: