Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Ord implementation for bitflags types #1095

Closed
kjughx opened this issue Nov 12, 2024 · 0 comments · Fixed by #1096
Closed

Missing Ord implementation for bitflags types #1095

kjughx opened this issue Nov 12, 2024 · 0 comments · Fixed by #1096

Comments

@kjughx
Copy link
Contributor

kjughx commented Nov 12, 2024

Between 0.17.0 and git2-0.18.0, bitflags was updated from 1.x to 2.1, where bitflags removed some derived traits on generated flags, including Ord which implies that all bitflags types now no longer are Ord. Being a minor release I'd expect it to backwards compatible but it no longer is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Maintain backwards compatibility for bitflags types kjughx/git2-rs
1 participant
@kjughx