Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

Add already-fixed ICEs? #1527

Closed
langston-barrett opened this issue Mar 14, 2023 · 3 comments
Closed

Add already-fixed ICEs? #1527

langston-barrett opened this issue Mar 14, 2023 · 3 comments

Comments

@langston-barrett
Copy link
Contributor

The README asks for test cases corresponding to open ICE issues. What about ones that have already been fixed? Might be helpful for #1156 and other purposes (e.g., seeding fuzzing corpora with interesting test cases).

@Alexendoo
Copy link
Member

Alexendoo commented Mar 14, 2023

For fixed ones the tests usually go in the main rust repo, we usually leave the issues open and mark them E-needs-test if the PR that fixed the ICE didn't add an appropriate test already

@langston-barrett
Copy link
Contributor Author

That makes sense! What about ICE issues that are recently filed and also have an open PR? Should they be left alone since they'll probably be closed soon? Or added in case the fix doesn't land promptly?

@Alexendoo
Copy link
Member

Yeah those are good to add too, they have occasionally caught a PR that didn't fully fix the issue

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants