-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate Roslyn's Red-Green trees. #21
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://github.com/KirillOsenkov/Bliki/wiki/Roslyn-Immutable-Trees
Incidentally, the children in our SPPF are encoded like a green tree (i.e. relative splits within the parent), it's just the "identity" of the nodes that includes their absolute range.
We could be allocating SPPF "green" nodes sequentially, and even deduplicate them after parsing (online deduplication seems... hard?), although that might be trickier after #9.
But for #12 (incremental reparsing) we'd still have to renumber the SPPF absolute ranges themselves, as we don't have a bottom-up parser, so we wouldn't gain anything from the indirection.
(And I'm not even sure we need any sort of "identity")
The text was updated successfully, but these errors were encountered: