Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aHash specialization support #248

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Mar 7, 2021

Unfortunately this feature causes compatibility issues with code that calculates hashes manually and then uses them with RawEntryBuilderMut::from_hash or RawEntryBuilderMut::from_key_hashed_nocheck.

We may want to re-introduce this in the future, but this would require a comprehensive plan to address the breakage.

@Amanieu
Copy link
Member Author

Amanieu commented Mar 8, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Mar 8, 2021

📌 Commit e7a7e4d has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Mar 8, 2021

⌛ Testing commit e7a7e4d with merge 0c8f029...

@bors
Copy link
Contributor

bors commented Mar 8, 2021

☀️ Test successful - checks-travis
Approved by: Amanieu
Pushing 0c8f029 to master...

@bors bors merged commit 0c8f029 into rust-lang:master Mar 8, 2021
@bors bors mentioned this pull request Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants