-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bucket::drop
and Bucket::read
need to be used with deprecated RawTable::erase_no_drop
#364
Comments
I thought about this for a bit and I think the best solution is to deprecate |
Actually we can remove the deprecated methods since the next version of hashbrown will be a major version bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm trying to document a raw part of the crate and was thinking about the safety concerns of the
Bucket<T>
methods, but I suddenly realized that the two public methods,Bucket::drop
andBucket::read
, potentially lead to double-drop inRawTable
, since they cannot be used withoutRawTable::erase_no_drop
but this method has been deprecated since version "0.8.1".So we need to come up with something:
RawTable::erase_no_drop
not a deprecated method;Bucket::drop
andBucket::read
methods? But it is not clear how to document this forBucket::drop
, theBucket::read
method can at least be used in conjunction withcore::mem::forget
.The text was updated successfully, but these errors were encountered: