Skip to content

bors squash left commit separate from PR/rollup in gh history #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
klensy opened this issue Sep 20, 2022 · 2 comments
Closed

bors squash left commit separate from PR/rollup in gh history #182

klensy opened this issue Sep 20, 2022 · 2 comments

Comments

@klensy
Copy link
Contributor

klensy commented Sep 20, 2022

PR: rust-lang/rust#101806

And now check github history: https://github.com/rust-lang/rust/commits?author=bors for Sep 20, 2022, there separate non PR/rollup commit.

squash bors command should be disabled: it used rarely, and if used, it sometimes(often?) works not in way as it expected.
@klensy
Copy link
Contributor Author

klensy commented Sep 20, 2022

And that PR affected by #181 too.

@jyn514
Copy link
Member

jyn514 commented Sep 20, 2022

Duplicate of #181

@jyn514 jyn514 marked this as a duplicate of #181 Sep 20, 2022
@jyn514 jyn514 closed this as completed Sep 20, 2022
@klensy klensy mentioned this issue Sep 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@klensy @jyn514