Skip to content

Commit a92ecf7

Browse files
tgross35tgross35
authored
Merge pull request #4231 from lvllvl/4117-part-3
Classify FIXMEs - 3
2 parents 989b64a + 861246a commit a92ecf7

File tree

9 files changed

+53
-53
lines changed

9 files changed

+53
-53
lines changed

‎src/unix/bsd/mod.rs

+6-6
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ cfg_if! {
185185
f.debug_struct("sockaddr_un")
186186
.field("sun_len", &self.sun_len)
187187
.field("sun_family", &self.sun_family)
188-
// FIXME: .field("sun_path", &self.sun_path)
188+
// FIXME(debug): .field("sun_path", &self.sun_path)
189189
.finish()
190190
}
191191
}
@@ -232,11 +232,11 @@ cfg_if! {
232232
impl fmt::Debug for utsname {
233233
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
234234
f.debug_struct("utsname")
235-
// FIXME: .field("sysname", &self.sysname)
236-
// FIXME: .field("nodename", &self.nodename)
237-
// FIXME: .field("release", &self.release)
238-
// FIXME: .field("version", &self.version)
239-
// FIXME: .field("machine", &self.machine)
235+
// FIXME(debug): .field("sysname", &self.sysname)
236+
// FIXME(debug): .field("nodename", &self.nodename)
237+
// FIXME(debug): .field("release", &self.release)
238+
// FIXME(debug): .field("version", &self.version)
239+
// FIXME(debug): .field("machine", &self.machine)
240240
.finish()
241241
}
242242
}

‎src/unix/bsd/netbsdlike/openbsd/mod.rs

+10-10
Original file line numberDiff line numberDiff line change
@@ -780,7 +780,7 @@ cfg_if! {
780780
.field("d_reclen", &self.d_reclen)
781781
.field("d_type", &self.d_type)
782782
.field("d_namlen", &self.d_namlen)
783-
// FIXME: .field("d_name", &self.d_name)
783+
// FIXME(debug): .field("d_name", &self.d_name)
784784
.finish()
785785
}
786786
}
@@ -873,8 +873,8 @@ cfg_if! {
873873
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
874874
f.debug_struct("lastlog")
875875
.field("ll_time", &self.ll_time)
876-
// FIXME: .field("ll_line", &self.ll_line)
877-
// FIXME: .field("ll_host", &self.ll_host)
876+
// FIXME(debug): .field("ll_line", &self.ll_line)
877+
// FIXME(debug): .field("ll_host", &self.ll_host)
878878
.finish()
879879
}
880880
}
@@ -913,9 +913,9 @@ cfg_if! {
913913
impl fmt::Debug for utmp {
914914
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
915915
f.debug_struct("utmp")
916-
// FIXME: .field("ut_line", &self.ut_line)
917-
// FIXME: .field("ut_name", &self.ut_name)
918-
// FIXME: .field("ut_host", &self.ut_host)
916+
// FIXME(debug): .field("ut_line", &self.ut_line)
917+
// FIXME(debug): .field("ut_name", &self.ut_name)
918+
// FIXME(debug): .field("ut_host", &self.ut_host)
919919
.field("ut_time", &self.ut_time)
920920
.finish()
921921
}
@@ -1048,10 +1048,10 @@ cfg_if! {
10481048
.field("f_namemax", &self.f_namemax)
10491049
.field("f_owner", &self.f_owner)
10501050
.field("f_ctime", &self.f_ctime)
1051-
// FIXME: .field("f_fstypename", &self.f_fstypename)
1052-
// FIXME: .field("f_mntonname", &self.f_mntonname)
1053-
// FIXME: .field("f_mntfromname", &self.f_mntfromname)
1054-
// FIXME: .field("f_mntfromspec", &self.f_mntfromspec)
1051+
// FIXME(debug): .field("f_fstypename", &self.f_fstypename)
1052+
// FIXME(debug): .field("f_mntonname", &self.f_mntonname)
1053+
// FIXME(debug): .field("f_mntfromname", &self.f_mntfromname)
1054+
// FIXME(debug): .field("f_mntfromspec", &self.f_mntfromspec)
10551055
.field("mount_info", &self.mount_info)
10561056
.finish()
10571057
}

‎src/unix/bsd/netbsdlike/openbsd/x86_64.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ cfg_if! {
9292
.field("fx_rdp", &{ self.fx_rdp })
9393
.field("fx_mxcsr", &{ self.fx_mxcsr })
9494
.field("fx_mxcsr_mask", &{ self.fx_mxcsr_mask })
95-
// FIXME: .field("fx_st", &{self.fx_st})
96-
// FIXME: .field("fx_xmm", &{self.fx_xmm})
95+
// FIXME(debug): .field("fx_st", &{self.fx_st})
96+
// FIXME(debug): .field("fx_xmm", &{self.fx_xmm})
9797
.finish()
9898
}
9999
}

‎src/unix/haiku/mod.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -562,7 +562,7 @@ cfg_if! {
562562
f.debug_struct("sockaddr_un")
563563
.field("sun_len", &self.sun_len)
564564
.field("sun_family", &self.sun_family)
565-
// FIXME: .field("sun_path", &self.sun_path)
565+
// FIXME(debug): .field("sun_path", &self.sun_path)
566566
.finish()
567567
}
568568
}
@@ -599,7 +599,7 @@ cfg_if! {
599599
.field("ss_family", &self.ss_family)
600600
.field("__ss_pad1", &self.__ss_pad1)
601601
.field("__ss_pad2", &self.__ss_pad2)
602-
// FIXME: .field("__ss_pad3", &self.__ss_pad3)
602+
// FIXME(debug): .field("__ss_pad3", &self.__ss_pad3)
603603
.finish()
604604
}
605605
}
@@ -636,7 +636,7 @@ cfg_if! {
636636
.field("d_ino", &self.d_ino)
637637
.field("d_pino", &self.d_pino)
638638
.field("d_reclen", &self.d_reclen)
639-
// FIXME: .field("d_name", &self.d_name)
639+
// FIXME(debug): .field("d_name", &self.d_name)
640640
.finish()
641641
}
642642
}
@@ -868,7 +868,7 @@ pub const LC_NUMERIC: c_int = 4;
868868
pub const LC_TIME: c_int = 5;
869869
pub const LC_MESSAGES: c_int = 6;
870870

871-
// FIXME: Haiku does not have MAP_FILE, but library/std/os.rs requires it
871+
// FIXME(haiku): Haiku does not have MAP_FILE, but library/std/os.rs requires it
872872
pub const MAP_FILE: c_int = 0x00;
873873
pub const MAP_SHARED: c_int = 0x01;
874874
pub const MAP_PRIVATE: c_int = 0x02;
@@ -1301,7 +1301,7 @@ pub const PTHREAD_MUTEX_NORMAL: c_int = 1;
13011301
pub const PTHREAD_MUTEX_ERRORCHECK: c_int = 2;
13021302
pub const PTHREAD_MUTEX_RECURSIVE: c_int = 3;
13031303

1304-
pub const FIOCLEX: c_ulong = 0; // FIXME: does not exist on Haiku!
1304+
pub const FIOCLEX: c_ulong = 0; // FIXME(haiku): does not exist on Haiku!
13051305

13061306
pub const RUSAGE_CHILDREN: c_int = -1;
13071307

‎src/unix/haiku/x86_64.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,9 @@ cfg_if! {
9494
.field("rdp", &self.rdp)
9595
.field("mxcsr", &self.mxcsr)
9696
.field("mscsr_mask", &self.mscsr_mask)
97-
// FIXME: .field("_fpreg", &self._fpreg)
98-
// FIXME: .field("_xmm", &self._xmm)
99-
// FIXME: .field("_reserved_416_511", &self._reserved_416_511)
97+
// FIXME(debug): .field("_fpreg", &self._fpreg)
98+
// FIXME(debug): .field("_xmm", &self._xmm)
99+
// FIXME(debug): .field("_reserved_416_511", &self._reserved_416_511)
100100
.finish()
101101
}
102102
}
@@ -133,7 +133,7 @@ cfg_if! {
133133
f.debug_struct("xstate_hdr")
134134
.field("bv", &self.bv)
135135
.field("xcomp_bv", &self.xcomp_bv)
136-
// FIXME: .field("_reserved", &field._reserved)
136+
// FIXME(debug): .field("_reserved", &field._reserved)
137137
.finish()
138138
}
139139
}
@@ -162,7 +162,7 @@ cfg_if! {
162162
f.debug_struct("savefpu")
163163
.field("fp_fxsave", &self.fp_fxsave)
164164
.field("fp_xstate", &self.fp_xstate)
165-
// FIXME: .field("_fp_ymm", &field._fp_ymm)
165+
// FIXME(debug): .field("_fp_ymm", &field._fp_ymm)
166166
.finish()
167167
}
168168
}

‎src/unix/linux_like/linux/gnu/b64/x86_64/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ s_no_extra_traits! {
308308
pub uc_mcontext: mcontext_t,
309309
pub uc_sigmask: crate::sigset_t,
310310
__private: [u8; 512],
311-
// FIXME(linux): the shadow stack field requires glibc >= 2.28.
311+
// FIXME(glibc): the shadow stack field requires glibc >= 2.28.
312312
// Re-add once we drop compatibility with glibc versions older than
313313
// 2.28.
314314
//

‎src/unix/linux_like/linux/musl/b32/hexagon.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ pub const SYS_clock_settime: c_int = 112;
286286
pub const SYS_clone: c_int = 220;
287287
pub const SYS_close: c_int = 57;
288288
pub const SYS_connect: c_int = 203;
289-
pub const SYS_copy_file_range: c_int = -1; // FIXME(musl)
289+
pub const SYS_copy_file_range: c_int = -1; // FIXME(hexagon)
290290
pub const SYS_creat: c_int = 1064;
291291
pub const SYS_delete_module: c_int = 106;
292292
pub const SYS_dup2: c_int = 1041;

‎src/unix/nto/mod.rs

+7-7
Original file line numberDiff line numberDiff line change
@@ -806,7 +806,7 @@ cfg_if! {
806806
f.debug_struct("sockaddr_un")
807807
.field("sun_len", &self.sun_len)
808808
.field("sun_family", &self.sun_family)
809-
// FIXME: .field("sun_path", &self.sun_path)
809+
// FIXME(debug): .field("sun_path", &self.sun_path)
810810
.finish()
811811
}
812812
}
@@ -1015,11 +1015,11 @@ cfg_if! {
10151015
impl fmt::Debug for utsname {
10161016
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
10171017
f.debug_struct("utsname")
1018-
// FIXME: .field("sysname", &self.sysname)
1019-
// FIXME: .field("nodename", &self.nodename)
1020-
// FIXME: .field("release", &self.release)
1021-
// FIXME: .field("version", &self.version)
1022-
// FIXME: .field("machine", &self.machine)
1018+
// FIXME(debug): .field("sysname", &self.sysname)
1019+
// FIXME(debug): .field("nodename", &self.nodename)
1020+
// FIXME(debug): .field("release", &self.release)
1021+
// FIXME(debug): .field("version", &self.version)
1022+
// FIXME(debug): .field("machine", &self.machine)
10231023
.finish()
10241024
}
10251025
}
@@ -1095,7 +1095,7 @@ cfg_if! {
10951095
.field("ss_family", &self.ss_family)
10961096
.field("__ss_pad1", &self.__ss_pad1)
10971097
.field("__ss_align", &self.__ss_align)
1098-
// FIXME: .field("__ss_pad2", &self.__ss_pad2)
1098+
// FIXME(debug): .field("__ss_pad2", &self.__ss_pad2)
10991099
.finish()
11001100
}
11011101
}

‎src/unix/solarish/mod.rs

+16-16
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,7 @@ cfg_if! {
589589
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
590590
f.debug_struct("sockaddr_un")
591591
.field("sun_family", &self.sun_family)
592-
// FIXME: .field("sun_path", &self.sun_path)
592+
// FIXME(debug): .field("sun_path", &self.sun_path)
593593
.finish()
594594
}
595595
}
@@ -632,11 +632,11 @@ cfg_if! {
632632
impl fmt::Debug for utsname {
633633
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
634634
f.debug_struct("utsname")
635-
// FIXME: .field("sysname", &self.sysname)
636-
// FIXME: .field("nodename", &self.nodename)
637-
// FIXME: .field("release", &self.release)
638-
// FIXME: .field("version", &self.version)
639-
// FIXME: .field("machine", &self.machine)
635+
// FIXME(debug): .field("sysname", &self.sysname)
636+
// FIXME(debug): .field("nodename", &self.nodename)
637+
// FIXME(debug): .field("release", &self.release)
638+
// FIXME(debug): .field("version", &self.version)
639+
// FIXME(debug): .field("machine", &self.machine)
640640
.finish()
641641
}
642642
}
@@ -662,7 +662,7 @@ cfg_if! {
662662
impl fmt::Debug for fd_set {
663663
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
664664
f.debug_struct("fd_set")
665-
// FIXME: .field("fds_bits", &self.fds_bits)
665+
// FIXME(debug): .field("fds_bits", &self.fds_bits)
666666
.finish()
667667
}
668668
}
@@ -691,7 +691,7 @@ cfg_if! {
691691
.field("ss_family", &self.ss_family)
692692
.field("__ss_pad1", &self.__ss_pad1)
693693
.field("__ss_align", &self.__ss_align)
694-
// FIXME: .field("__ss_pad2", &self.__ss_pad2)
694+
// FIXME(debug): .field("__ss_pad2", &self.__ss_pad2)
695695
.finish()
696696
}
697697
}
@@ -740,7 +740,7 @@ cfg_if! {
740740
&& self.si_code == other.si_code
741741
&& self.si_errno == other.si_errno
742742
{
743-
// FIXME: The `si_pad` field in the 64-bit version of the struct is ignored
743+
// FIXME(solarish): The `si_pad` field in the 64-bit version of the struct is ignored
744744
// (for now) when doing comparisons.
745745

746746
let field_count = self.data_field_count();
@@ -760,7 +760,7 @@ cfg_if! {
760760
.field("si_signo", &self.si_signo)
761761
.field("si_code", &self.si_code)
762762
.field("si_errno", &self.si_errno)
763-
// FIXME: .field("__pad", &self.__pad)
763+
// FIXME(debug): .field("__pad", &self.__pad)
764764
.finish()
765765
}
766766
}
@@ -770,7 +770,7 @@ cfg_if! {
770770
self.si_code.hash(state);
771771
self.si_errno.hash(state);
772772

773-
// FIXME: The `si_pad` field in the 64-bit version of the struct is ignored
773+
// FIXME(solarish): The `si_pad` field in the 64-bit version of the struct is ignored
774774
// (for now) when doing hashing.
775775

776776
let field_count = self.data_field_count();
@@ -803,7 +803,7 @@ cfg_if! {
803803
.field("sdl_nlen", &self.sdl_nlen)
804804
.field("sdl_alen", &self.sdl_alen)
805805
.field("sdl_slen", &self.sdl_slen)
806-
// FIXME: .field("sdl_data", &self.sdl_data)
806+
// FIXME(debug): .field("sdl_data", &self.sdl_data)
807807
.finish()
808808
}
809809
}
@@ -853,7 +853,7 @@ cfg_if! {
853853
impl PartialEq for pad128_t {
854854
fn eq(&self, other: &pad128_t) -> bool {
855855
unsafe {
856-
// FIXME: self._q == other._q ||
856+
// FIXME(solarish): self._q == other._q ||
857857
self._l == other._l
858858
}
859859
}
@@ -862,15 +862,15 @@ cfg_if! {
862862
impl hash::Hash for pad128_t {
863863
fn hash<H: hash::Hasher>(&self, state: &mut H) {
864864
unsafe {
865-
// FIXME: state.write_i64(self._q as i64);
865+
// FIXME(solarish): state.write_i64(self._q as i64);
866866
self._l.hash(state);
867867
}
868868
}
869869
}
870870
impl PartialEq for upad128_t {
871871
fn eq(&self, other: &upad128_t) -> bool {
872872
unsafe {
873-
// FIXME: self._q == other._q ||
873+
// FIXME(solarish): self._q == other._q ||
874874
self._l == other._l
875875
}
876876
}
@@ -879,7 +879,7 @@ cfg_if! {
879879
impl hash::Hash for upad128_t {
880880
fn hash<H: hash::Hasher>(&self, state: &mut H) {
881881
unsafe {
882-
// FIXME: state.write_i64(self._q as i64);
882+
// FIXME(solarish): state.write_i64(self._q as i64);
883883
self._l.hash(state);
884884
}
885885
}

0 commit comments

Comments
 (0)