Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing tag / crates.io update for version 0.2.64 #1515

Closed
loganwendholt opened this issue Sep 12, 2019 · 9 comments
Closed

Missing tag / crates.io update for version 0.2.64 #1515

loganwendholt opened this issue Sep 12, 2019 · 9 comments

Comments

@loganwendholt
Copy link
Contributor

As of right now, the latest tag version is 0.2.63, but the Cargo.toml version was bumped to 0.2.64 with commit 1dd09fb. In addition, crates.io has a 0.2.63, but it has been yanked.

Could we get a 0.2.64 tag in place and update crates.io?
@gnzlbg
Copy link
Contributor

gnzlbg commented Sep 12, 2019

There are some bugs upstream that must be fixed before we can release 0.2.64. Right now, the latest usable version is 0.2.62. The 0.2.63 had a serious bug and was yanked, the tag should reflect that.

Once 0.2.64 is released, the commit that correspond to the code in that release will be tagged.

@loganwendholt
Copy link
Contributor Author

Got it, thanks for the clarification!

@mati865 mati865 mentioned this issue Sep 13, 2019
Merged
@newpavlov newpavlov mentioned this issue Sep 18, 2019
Merged
@loganwendholt
Copy link
Contributor Author

Are there any specific issues / PRs related to the bugs that are blocking?

@Osspial
Copy link

Osspial commented Oct 5, 2019

The one problem I can find with 0.2.63 was an issue with musl, and the code causing that breakage has been removed. I can't find anything else that would be blocking, but I'm not all that familiar with this crate so I don't know if there's something else.

@Osspial
Copy link

Osspial commented Oct 6, 2019

Looking through the diff from 0.2.63 to now, the other issue that's mentioned is rust-lang/rust#63649, but that has also been resolved.

@tlively
Copy link
Contributor

tlively commented Oct 8, 2019

rust-lang/rust#63649 was rolled back in rust-lang/rust#65151, but that should not block a new libc release. The Emscripten fixes in #1478 are independent of rust-lang/rust#63649 and should be rolled into rust-lang/rust as soon as possible regardless of what happens with other PRs.

@newpavlov
Copy link
Contributor

@gnzlbg
Any news regarding ETA for v0.2.64 release?

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 15, 2019 •
edited
Loading

As soon as bors reports all green, which is hopefully today. Last week some smaller components for the standard library were shipped, and those were missing some binary components that were required for some targets to work properly, but the fix landed on nightly today. But... the new rustup profiles also landed today, and that broke CI in different ways on some targets as well... #1550 fixes that there, and afterwards I can do a release.

@gnzlbg
Copy link
Contributor

gnzlbg commented Oct 15, 2019

0.2.64 has been released, please, do test and report any issues, I'll update rust-lang/rust to use this version after it has received some testing

@gnzlbg gnzlbg closed this as completed Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@newpavlov @gnzlbg @tlively @loganwendholt @Osspial