Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port newlib's exp2f #136

Closed
japaric opened this issue Jul 27, 2018 · 2 comments · May be fixed by #169
Closed

port newlib's exp2f #136

japaric opened this issue Jul 27, 2018 · 2 comments · May be fixed by #169
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone
newlib

Comments

@japaric
Copy link
Member

japaric commented Jul 27, 2018

Source: https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;a=blob;f=newlib/libm/math/wf_exp2.c;hb=HEAD

Rationale: the current implementation makes use of f64 and it has bad performance on architectures that have no hardware support for double precision floats.

What needs to be done:

  • Move the existing MUSL port into a private math::musl module and make sure we continue compiling it.
  • Port the newlib version into src/math/$fun.rs
  • Update the test suite by uncommenting the function name in tests/newlib.rs and removing the function name from tests/musl.rs.
@japaric japaric added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 27, 2018
@japaric japaric added this to the newlib milestone Jul 27, 2018
@Schultzer Schultzer mentioned this issue May 17, 2019
Open
@tesuji
Copy link

tesuji commented May 25, 2019 •
edited
Loading

Look like someone already do it.

@tgross35
Copy link
Contributor

tgross35 commented Jan 6, 2025

I am closing all newlib issues; please see #133 (comment) for context.

@tgross35 tgross35 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
newlib
Development

Successfully merging a pull request may close this issue.

Add newlib exp2f Schultzer/libm
3 participants
@japaric @tgross35 @tesuji