Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUMMARY.md can no longer contain HTML comments #1096

Closed
Michael-F-Bryan opened this issue Nov 13, 2019 · 2 comments · Fixed by #1167
Closed

SUMMARY.md can no longer contain HTML comments #1096

Michael-F-Bryan opened this issue Nov 13, 2019 · 2 comments · Fixed by #1167

Comments

@Michael-F-Bryan
Copy link
Contributor

In one of my books I comment out not-yet-written chapters using HTML comments. After updating from v0.3.4 to v0.3.5 running mdbook build now fails while parsing SUMMARY.md.

$ mdbook build
2019-11-13 10:00:58 [ERROR] (mdbook::utils): Error: Summary parsing failed
2019-11-13 10:00:58 [ERROR] (mdbook::utils):    Caused By: There was an error parsing the numbered chapters
2019-11-13 10:00:58 [ERROR] (mdbook::utils):    Caused By: Unable to get last link because the list of SummaryItems doesn't contain any Links

I believe the regression was introduced in #1021 when pulldown-cmark was updated.
@Michael-F-Bryan
Copy link
Contributor Author

Minimal, reproducible example:

# Summary

- [First](./first.md)
<!-- this is a comment -->
- [Second](./second.md)

@EasiestSoft
Copy link

I also hope this will be resolved soon

@dalance dalance mentioned this issue Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SUMMARY's parse_numbered with comment dalance/mdBook
2 participants
@Michael-F-Bryan @EasiestSoft