book is not truly offline

[steveklabnik]

Originally filed as rust-lang/rust#44826

It'd be good to have a 100% offline mode for the local docs. We used to do this; I'm assuming some stuff sneaked in!

[azerupi]

There have been a lot of different issues with the CDN related code. I am beginning to think we should remove it altogether. Loading everything from local sources would solve this issue.

[Michael-F-Bryan]

Would it be better to vendor all required static assets and have them embedded in the mdbook binary? Then whenever we want to change/update an asset, it'll be added to the themes/ directory with a corresponding include_bytes().

[jacwah]

Vendoring js assets through include_bytes! would be easier if we first concatenate them to a single file. This could be done through a build step similar to regen css.

cat src/theme/*.js > src/theme/vendor.js

Then there's only a single file to vendor. This would probably improve performance as well, since fewer http requests are made from the browser.

[Michael-F-Bryan]

Vendoring js assets through include_bytes! would be easier if we first concatenate them to a single file

I'm not sure how well this would work out. We currently allow people to override various CSS/JS files if they are present in a src/themes/ directory. If the vendored versions were all concatenated together then I don't know how easy it'd be to split them apart again to exclude one or two that the user has overridden.

[jacwah]

We currently allow people to override various CSS/JS files if they are present in a src/themes/ directory.

Oh, right. I was unaware of that.

[sanmai-NL]

@steveklabnik Can this be closed in favor of #546?