Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a before load script #60

Closed
mdinger opened this issue Sep 24, 2015 · 1 comment
Closed

Create a before load script #60

mdinger opened this issue Sep 24, 2015 · 1 comment

Comments

@mdinger
Copy link
Contributor

mdinger commented Sep 24, 2015

Making sure the theme is preserved on load and when clicking back and such requires rerunning all scripts. It might be good to consolidate all before page load scripts together for better structure but also so the local storage items can be triggered alone without everything having to run.

For example, the current script doesn't even check if the correct highlighting css files are enabled. Though this used to be an issue, rerunning all scripts on page load probably brute force solved the issue. It still doesn't seem like a neat solution.

@azerupi azerupi added this to the 0.0.3 milestone Sep 25, 2015
@azerupi azerupi removed this from the 0.0.4 milestone Dec 29, 2015
@azerupi
Copy link
Contributor

azerupi commented Jan 9, 2016

This will probably change with #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants