Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve theme for highlighting toml config #890

Closed
tesuji opened this issue Mar 21, 2019 · 5 comments · Fixed by #942
Closed

Improve theme for highlighting toml config #890

tesuji opened this issue Mar 21, 2019 · 5 comments · Fixed by #942
Labels
A-Highlighting Area: Code colored syntax highlighting

Comments

@tesuji
Copy link
Contributor

tesuji commented Mar 21, 2019

From https://doc.rust-lang.org/nightly/cargo/reference/config.html#configuration-keys
image
@ehuss ehuss added the A-Highlighting Area: Code colored syntax highlighting label May 17, 2019
@tesuji tesuji mentioned this issue May 24, 2019
Closed
@tesuji
Copy link
Contributor Author

tesuji commented May 24, 2019

To test highlighter.js and prism syntax highlighter, I wrote this gist:
https://gist.github.com/lzutao/f5513a5d9a122d1cbf846f2f097fad7f

Screenshot of that gist:
image

@tesuji
Copy link
Contributor Author

tesuji commented May 24, 2019

cc highlightjs/highlight.js#2040

@ehuss
Copy link
Contributor

ehuss commented May 24, 2019

I already opened a hljs PR a few days ago: highlightjs/highlight.js#2039

@tesuji
Copy link
Contributor Author

tesuji commented May 24, 2019

Glad to know that! Looking forward for you PR to beging merged.

@tesuji
Copy link
Contributor Author

tesuji commented May 29, 2019

Now your PR is merged. highlight.js released new version. I took a look
to update mdbok but it has change too much: from highlight.js to highlight.pack.js,
and remove highlight.css. That's too much for me.

Could you update it instead?

@ehuss ehuss mentioned this issue May 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Highlighting Area: Code colored syntax highlighting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update highlight.js ehuss/mdBook
2 participants
@ehuss @tesuji