-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stack_collapse unit tests fail on Windows #173
Comments
Turns out the issue is that Windows SystemTime does not support time intervals smaller than 100 nanoseconds. The tests are using intervals much smaller than that and when we add a duration to system times that are smaller than 100 nanoseconds, you'll end up not actually adding any time (i.e., the system time you get after the addition is the same as the one before). You can see where we divide nanoseconds into 100 nanosecond chunks in stdlib here. To fix this we need to use a time mechanism that has more precision than 100 nanosecond intervals. |
@eddyb mentioned that a fix for this should also take care of the case when we are not actually dealing with timestamps, such as when recording instructions counts. |
For generalized handling of counters, we've been serializing this as measureme/measureme/src/counters.rs Lines 148 to 158 in 1d904b7
So we should be able to pretty-print an |
For some reason the unit tests in stack_collapse.rs fail on Windows (at least for me locally), even though they don't seem to contain anything platform specific.
cc @wesleywiser
The text was updated successfully, but these errors were encountered: