Skip to content

Commit ee9ffad

Browse files
committed
Fix review comments
1 parent b6fcae9 commit ee9ffad

File tree

6 files changed

+3
-28
lines changed

6 files changed

+3
-28
lines changed

cargo-miri/src/setup.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ pub fn setup(
160160

161161
// Do the build.
162162
let status = SysrootBuilder::new(&sysroot_dir, target)
163-
.build_mode(BuildMode::Build)
163+
.build_mode(BuildMode::Build) // not a real build, since we use dummy codegen
164164
.rustc_version(rustc_version.clone())
165165
.sysroot_config(sysroot_config)
166166
.rustflags(rustflags)

src/bin/miri.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ impl rustc_driver::Callbacks for MiriBeRustCompilerCalls {
239239
// which will be used later in non-`MIRI_BE_RUSTC` mode.
240240
config.override_queries = Some(|_, local_providers| {
241241
// We need to add #[used] symbols to exported_symbols for `lookup_link_section`.
242-
// FIXME handle this somehow in rustc itself to avoid this hack
242+
// FIXME handle this somehow in rustc itself to avoid this hack.
243243
local_providers.exported_non_generic_symbols = |tcx, LocalCrate| {
244244
let reachable_set = tcx.with_stable_hashing_context(|hcx| {
245245
tcx.reachable_set(()).to_sorted(&hcx, true)

test-cargo-miri/Cargo.lock

Lines changed: 0 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test-cargo-miri/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[workspace]
2-
members = ["cdylib", "subcrate", "issue-1567", "exported-symbol-dep", "test-local-crate-detection"]
2+
members = ["subcrate", "issue-1567", "exported-symbol-dep", "test-local-crate-detection"]
33
exclude = ["no-std-smoke"] # it wants to be panic="abort"
44

55
[package]

test-cargo-miri/cdylib/Cargo.toml

Lines changed: 0 additions & 12 deletions
This file was deleted.

test-cargo-miri/cdylib/src/lib.rs

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)