Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Posix → Unix #2012

Closed
RalfJung opened this issue Mar 9, 2022 · 6 comments · Fixed by #2198
Closed

Rename Posix → Unix #2012

RalfJung opened this issue Mar 9, 2022 · 6 comments · Fixed by #2198
Labels
A-linux Area: affects only Linux targets A-mac Area: Affects only macOS targets C-cleanup Category: cleaning up our code E-good-first-issue A good way to start contributing, mentoring is available

Comments

@RalfJung
Copy link
Member

RalfJung commented Mar 9, 2022

In Miri, we use the term "POSIX" to refer to the functionality shared between Linux and macOS (and soon, Android: #2011). I used that term because those files started essentially as an implementation of a small part of the POSIX API.

However, in the Rust standard library, the term used for grouping those platforms is "Unix", and there also is target_family = "unix". So I think it would make to rename "posix" to "unix" in the Miri codebase. This should be an easy change. However, it should wait until #2011 lands to reduce merge conflicts.

@RalfJung RalfJung added the E-good-first-issue A good way to start contributing, mentoring is available label Mar 9, 2022
@b-ncMN
Copy link
Contributor

b-ncMN commented Jun 2, 2022

I am willing to do this, I'll make a draft PR that can be merged after #2011 landed

@b-ncMN
Copy link
Contributor

b-ncMN commented Jun 2, 2022

@rustbot claim

@rustbot
Copy link
Collaborator

rustbot commented Jun 2, 2022

Error: This repository is not enabled to use triagebot.
Add a triagebot.toml in the root of the master branch to enable it.

Please let @rust-lang/release know if you're having trouble with this bot.

@RalfJung
Copy link
Member Author

RalfJung commented Jun 3, 2022

No rustbot in this repo, but we can track this by hand. :) Thanks for chiming in!

#2011 is still a draft; @landaire know best whether it makes sense to wait for that or whether we can go ahead and let them deal with the merge conflicts as they arise.

@landaire
Copy link
Contributor

landaire commented Jun 3, 2022

I apologize for the delay on #2011. I've been busier than expected recently... I can deal with merge conflicts as they come.

@b-ncMN
Copy link
Contributor

b-ncMN commented Jun 4, 2022

I apologize for the delay on #2011. I've been busier than expected recently... I can deal with merge conflicts as they come.

No worries 😉

@RalfJung RalfJung added A-mac Area: Affects only macOS targets A-linux Area: affects only Linux targets C-cleanup Category: cleaning up our code labels Jun 5, 2022
@bors bors closed this as completed in fc8631a Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linux Area: affects only Linux targets A-mac Area: Affects only macOS targets C-cleanup Category: cleaning up our code E-good-first-issue A good way to start contributing, mentoring is available
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants