Skip to content

ui_test parallelism does not work as expected #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RalfJung opened this issue Jun 6, 2022 · 0 comments · Fixed by #2207
Closed

ui_test parallelism does not work as expected #2204

RalfJung opened this issue Jun 6, 2022 · 0 comments · Fixed by #2207

Comments

@RalfJung
Copy link
Member

RalfJung commented Jun 6, 2022

I was wondering why tests seem to execute so sequentially. I think I figured it out: each of our N threads runs while let Some(path) = todo.pop() {; that means if the queue is ever empty when they look at it, the thread terminates and does not come back!

I think we might want to use rayon with its thread pool, rather than trying an ad-hoc implementation of a threadpool ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant