Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"./miri test" builds Miri twice #3091

Closed
RalfJung opened this issue Sep 28, 2023 · 1 comment
Closed

"./miri test" builds Miri twice #3091

RalfJung opened this issue Sep 28, 2023 · 1 comment

Comments

@RalfJung
Copy link
Member

RalfJung commented Sep 28, 2023

We (again) have some dependency situation which leads to Miri being built twice for ./miri test -- likely one of our dev-dependencies enables a feature on another dependency that is shared with a regular build of Miri and so the Miri binary gets rebuilt by cargo.

Is there any way we can automatically test this, and avoid having to manually track this down at least once a year?

Is there some cargo bugreport that would have cargo re-use the perfectly fine miri binary that we have rather than re-building it with more features enabled that we didn't need?

@RalfJung
Copy link
Member Author

For now I worked around this by always telling cargo to build everything... only ./miri run still has a separate build now.

#3372 may be a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant