You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
cargo-miri and the Miri driver do a bunch of processing with the arguments passed to rustc -- that's terrible but currently not really avoidable. However we are entirely ignoring the existence of argument files, which already caused #3404 and could cause further issues in the future. So we should fix that.
cargo-miri: this is where most of the argument parsing and patching happens
For things that just scan the arguments, we should recurse into argument files so we can scan them as well.
When we are patching arguments (like replacing rlib by rmeta in --extern or filtering out certain flags), I'm not sure what to do -- either we just say argument files are not supported there, or we pass these arguments directly without files (which risks issues on Windows), or we have to generate our own argument files.
miri driver: needs to do argument parsing to set a default sysroot. Ideally we can just avoid having to do that. I tied two approaches for that:
Turns out cargo will use argfiles "on demand": if spawning the process fails because the argument list was too long, it falls back to an argfile. So that could lead to some very strange failures modes for Miri where when the number of dependencies exceeds some limit, suddenly cargo miri stops working on Windows...
cargo-miri and the Miri driver do a bunch of processing with the arguments passed to rustc -- that's terrible but currently not really avoidable. However we are entirely ignoring the existence of argument files, which already caused #3404 and could cause further issues in the future. So we should fix that.
--extern
or filtering out certain flags), I'm not sure what to do -- either we just say argument files are not supported there, or we pass these arguments directly without files (which risks issues on Windows), or we have to generate our own argument files.The text was updated successfully, but these errors were encountered: