Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining compile-fail tests #382

Closed
1 of 5 tasks
oli-obk opened this issue Jun 5, 2018 · 5 comments
Closed
1 of 5 tasks

Fix remaining compile-fail tests #382

oli-obk opened this issue Jun 5, 2018 · 5 comments

Comments

@oli-obk
Copy link
Contributor

oli-obk commented Jun 5, 2018

  • compile-fail/match_char2.rs
  • compile-fail/memleak.rs
  • compile-fail/memleak_rc.rs
  • compile-fail/overflowing-rsh-2.rs
  • compile-fail/static_memory_modification.rs
@RalfJung
Copy link
Member

I am seeing 11 failures, not 5:

failures:
    [compile-fail] compile-fail/deallocate-bad-alignment.rs
    [compile-fail] compile-fail/deallocate-bad-size.rs
    [compile-fail] compile-fail/deallocate-twice.rs
    [compile-fail] compile-fail/match_char.rs
    [compile-fail] compile-fail/memleak.rs
    [compile-fail] compile-fail/memleak_rc.rs
    [compile-fail] compile-fail/overflowing-rsh-2.rs
    [compile-fail] compile-fail/reallocate-bad-size.rs
    [compile-fail] compile-fail/reallocate-change-alloc.rs
    [compile-fail] compile-fail/reallocate-dangling.rs
    [compile-fail] compile-fail/static_memory_modification.rs

@RalfJung
Copy link
Member

#395 fixes most of them except for

  • compile-fail/match_char.rs
  • compile-fail/memleak.rs
  • compile-fail/memleak_rc.rs
  • compile-fail/static_memory_modification.rs

@oli-obk Why did we stop complaining about writes to static, and out-of-range char (but not bool)?

@oli-obk
Copy link
Contributor Author

oli-obk commented Jul 11, 2018

A bunch of refactorings. I'll reintroduce it properly once the sanity check PR is merged

@RalfJung
Copy link
Member

I opened #439 specifically for memory leaks.

@RalfJung
Copy link
Member

I have allowed myself to change the char test in the list; compile-fail/match_char2.rs is reasonable to reject in the current state whereas match_char requires a proper implementation of an all-value validity check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants