Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miri is very slow #654

Closed
gnzlbg opened this issue Mar 7, 2019 · 4 comments
Closed

Miri is very slow #654

gnzlbg opened this issue Mar 7, 2019 · 4 comments
Labels
A-interpreter Area: affects the core interpreter C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement

Comments

@gnzlbg
Copy link

gnzlbg commented Mar 7, 2019

Hashbrown's unit test test_lots_of_insertions takes too long to run under miri.
Maybe it might be worth to investigate what this test does and see if there are any low hanging fruit optimizations that can be applied to miri to make it run faster.

@RalfJung
Copy link
Member

RalfJung commented Mar 8, 2019

Yeah, Miri is pretty slow -- not sure how useful it is to keep a bug about that open, but whatever.

@RalfJung RalfJung added C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement A-interpreter Area: affects the core interpreter labels Mar 8, 2019
@RalfJung RalfJung changed the title hashbrow test_lots_of_insertions takes too long Miri is very slow Mar 8, 2019
@elichai
Copy link
Contributor

elichai commented Feb 12, 2020

So Miri just took all my 32GB of RAM + 4GB of swap. I'll try to see if I can pinpoint where/what takes so much memory, but it did seem like there's not a lot of cleanup after each test is finished

@RalfJung
Copy link
Member

Do we want to keep some kind of general tracking issue open for the perf problems or does that not make sense?

@oli-obk
Copy link
Contributor

oli-obk commented Apr 24, 2023

If we have specific slow examples, we can open issues for those, but a tracking issue (that hasn't seen a comment in 3 years and no cross reference in 2) is probably not too useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-interpreter Area: affects the core interpreter C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement
Projects
None yet
Development

No branches or pull requests

4 participants