Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break the analysis pipeline into components #112

Open
amandasystems opened this issue Aug 30, 2019 · 0 comments
Open

break the analysis pipeline into components #112

amandasystems opened this issue Aug 30, 2019 · 0 comments

Comments

@amandasystems
Copy link
Contributor

amandasystems commented Aug 30, 2019

Currently, the each Poloniu Algorithm's compute() method performs initialisation analysis, then liveness calculations, and then the actual Polonius implementation. This means a lot of code duplication and in the case of the hybrid algorithm that all of this happens twice.

I suggest the following for a minimal modification to the current setup:

  • the publicly visible compute() method still takes the gigantonormous AllFacts for now
  • internally, these facts are split up into internal data structures consumed by the various compute() methods
  • the calls initiating initialisation and liveness calculations happen in output::compute()
@amandasystems amandasystems changed the title Break the analysis pipeline into components break the analysis pipeline into components Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant