Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add the LoongArch stabilized target features #1707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Jan 3, 2025

This PR adds the stabilized target features as part of rust-lang/rust#135015.

@rustbot rustbot added the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Jan 3, 2025
@heiher heiher force-pushed the loong-target-features branch from bc1984d to f07ba46 Compare January 3, 2025 07:05
@ehuss ehuss added the S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository label Jan 7, 2025
Comment on lines 243 to 244
[LoongArch Reference Manual]: https://github.com/loongson/LoongArch-Documentation
[LoongArch GitHub Account]: https://github.com/loongson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there documentation that is more alive than these links? The documentation link looks like it is archived, and I don't know what else I would look at on the GitHub account. Is there a new location where the documentation lives? Is there a way to deep-link to the individual features (like wasm does)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The currently available English documentation is at https://github.com/loongson/LoongArch-Documentation. If a better option becomes available in the future, I will update it. Since not all target features have fragment identifiers, they point to the nearest location.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you say more about what's going on with the public documentation? Do you know why it is archived? Is there an actively maintained copy of the Chinese version? Are there any intentions to revive the English version, or is it moving somewhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course! Based on the latest info I've received, the LoongArch-Documentation is not permanently archived and is still maintained, with updates made as needed. It's currently the only source for the referenced information in English. The Chinese version can be downloaded from: 龙芯架构参考手册卷一-r1p11.pdf. There might be a new English version released in the future, though there's no clear timeline for that yet. The potential update is more about improving the formatting rather than addressing any issues with the existing content.

@ehuss ehuss added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-review Status: The marked PR is awaiting review from a maintainer labels Jan 9, 2025
@rustbot

This comment has been minimized.

@heiher heiher force-pushed the loong-target-features branch from f07ba46 to 5f09209 Compare March 18, 2025 06:43
@heiher
Copy link
Contributor Author

heiher commented Mar 18, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: The marked PR is awaiting review from a maintainer and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: The marked PR is awaiting review from a maintainer S-waiting-on-stabilization Waiting for a stabilization PR to be merged in the main Rust repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants