Skip to content

Commit 55860d5

Browse files
committed
Expand all 'other questions' into their own section
1 parent 53ba19d commit 55860d5

File tree

1 file changed

+44
-12
lines changed

1 file changed

+44
-12
lines changed

text/0000-erfc-post-build-contexts.md

+44-12
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,9 @@ and `--attribute=your_crate::harness`.
296296
[unresolved]: #unresolved-questions
297297

298298
These are mostly intended to be resolved during the experimental
299-
feature.
299+
feature. Many of these have strawman proposals -- unlike the rest of this RFC,
300+
these proposals have not been discussed as thoroughly. If folks feel like
301+
there's consensus on some of these we can move them into the main RFC.
300302

301303
## Integration with doctests
302304

@@ -367,15 +369,45 @@ iterated on later. Naming the feature is hard, some candidates are:
367369

368370
None of these are particularly great, ideas would be nice.
369371

370-
## Other questions
371-
372-
- Should a post-build context be able to declare "defaults" for what
373-
folders and post-build sets it should be added to? This might save
374-
users from some boilerplate in a large number of situations.
375-
- Should we be shipping a bencher by default at all (i.e., in libtest)?
376-
Could we instead default `cargo bench` to a `rust-lang-nursery`
377-
crate?
378-
- `specify-single-target = true` probably should be specified by the execution context itself,
379-
not the consumer. It's also questionable if it's necessary -- cargo-fuzz is going to need
380-
a wrapper script anyway, so it's fine if the CLI isn't as ergonomic for that use case.
372+
## Default folders and sets
373+
374+
Should a post-build context be able to declare "defaults" for what folders and post-build sets it
375+
should be added to? This might save users from some boilerplate in a large number of situations.
376+
377+
This could be done in the Cargo.toml as:
378+
379+
```toml
380+
[post-build.defaults]
381+
folder = "tests/"
382+
set = "test" # will automatically be added to the `test` set
383+
```
384+
385+
This is useful if a crate wishes to standardize things.
386+
387+
## Bencher
388+
389+
Should we be shipping a bencher by default at all (i.e., in libtest)? Could we instead default
390+
`cargo bench` to a `rust-lang-nursery` `bench` crate?
391+
392+
If this RFC lands and [RFC 2287] is rejected, we should probably try to stabilize
393+
`test::black_box` in some form (maybe `mem::black_box` and `mem::clobber` as detailed
394+
in [this amendment]).
395+
396+
397+
398+
[RFC 2287]: https://github.com/rust-lang/rfcs/pull/2287
399+
[this amendment]: https://github.com/Manishearth/rfcs/pull/1
400+
401+
## Specify-single-target
402+
403+
`specify-single-target = true` probably should be specified by the execution context itself, not the
404+
consumer. It's also questionable if it's necessary -- cargo-fuzz is going to need a wrapper script
405+
anyway, so it's fine if the CLI isn't as ergonomic for that use case.
406+
407+
If we do `post-build.defaults` it would just make sense to include that there.
408+
409+
410+
411+
412+
381413

0 commit comments

Comments
 (0)