-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: trait-declared associated type synonyms #313
Comments
there are no gotchas for assoicated data families, none. they're great! NB that associate data families!= associated type families (and i think rust is currently only providing associated type families?) one really really nice thing about data families is they provide injectivity so that knowing the type of the data family instance tells you what the index should be! This is not the case with type families. |
I would like to extend this proposal with the ability to declare both abstract and concrete types as trait members. (Presently, associated types can only be abstract.) My current use case is doing something like this:
In implementations, the programmer must only provide definitions for those type members that are abstract in the original trait:
The benefits of this approach are:
|
@eduardoleon the associated types proposal has support for defining default type expressions for a given associated type. So your example could be written there as something like this (right?): pub mod input { pub enum Step<S, E, L> { Cont(E, S), Done(L) } }
pub mod output { pub enum Step<S, L> { Cont(S), Done(L) } }
pub trait InputIterator {
type Element; // abstract
type Leftovers; // abstract
type Step = input::Step<Self, Element, Leftovers>;
fn get(self) -> Step;
}
pub trait OutputIterator {
type Element;
type Leftovers;
type Step = output::Step<Self, Element, Leftovers>;
fn put(self, Element) -> Step;
} |
@pnkfelix It can be written like that... with some caveats. One thing that worries me is that, presently, associated types can be overriden by the programmer in trait implementations. I need external users to be able to pattern-match on
The pattern matching done above is unsound if type members are overridable. I am aware that this can be worked around by not defining
|
I sort of like the idea of having concrete types, but I'm puzzled. Shouldn't something like the following be possible under the existing RFC? pub enum InputStep<I: InputIterator> {
Cont(I::Element, I),
Done(I::Leftovers),
}
pub enum ZipInputLeftovers<L: InputIterator, R: InputIterator> {
More1(L::Element, L, R::Leftovers),
More2(L::Leftovers, R::Element, R),
Neither(L::Leftovers, R::Leftovers),
} Of course this is more verbose than being able to inline these in the trait or impl, and you have to use names like |
I'm going to close this ticket; at this point, the addition of associated items to the language has addressed the original problem that prompted me to file it back in early 2013, and any suggestions of further changes should be filed as separate tickets rather than appended here. |
Note: Much or all of the feature requested here should be covered by RFC PR #195
Issue by pnkfelix
Tuesday Feb 19, 2013 at 16:15 GMT
For earlier discussion, see rust-lang/rust#5033
This issue was labelled with: A-servo, A-traits, A-typesystem, B-RFC, I-enhancement, P-high in the Rust repository
Rust's type system reflects many advances in the state of the art.
However, there is one feature (offered by C++ and ML) that is not present in Rust: The ability to declare within a trait a named type (and then each impl item would be obligated to bind that name to an appropriate type for the implementation).
Related work: See Garcia et al. 2003, especially section 6.2, 10.2, and 10.3. Another useful reference is Chakravarty et al 2005
The Haskell community calls such a construct an "associated type synonym."
Here is an small example to illustrate the idea.
First, the easy part: how such a feature would look at the level of trait and impl items:
Ideally one would extract the type from a trait by using a path, using a type parameter as a path component. So for example:
Note: I am aware that one can express currently express type synonyms in much the same way that one does in Java (or C#, or Eiffel; see Garcia et al paper): by making them a type-parameter of the trait itself. Rust's type-inference system does make that workaround more palatable, but it seems natural to enable the developer to express what they mean more directly: These types are obligations of the implementation, much like the functions declared in the trait, and thus it makes sense to express them the same way.
There are various issues to consider: e.g.:
Despite the above issues, this seems like a relatively straightforward change to the language (especially since one can already encode the pattern, so adding it should not inject e..g any type soundness bugs, right?).
The text was updated successfully, but these errors were encountered: