Overflow on num::rational::Ratio

[rust-highfive]

(moved to rust-num/num#12 )

Issue by klutzy
Wednesday Aug 27, 2014 at 07:50 GMT

For earlier discussion, see rust-lang/rust#16782

This issue was labelled with: in the Rust repository

---

use std::i64::MIN;
use:num::rational::Ratio;

let a = Ratio::new(1, MIN);

Here a actually is -1 / MIN due to overflow in reduce():

        // keep denom positive!
        if self.denom < Zero::zero() {
            self.numer = -self.numer;
            self.denom = -self.denom;
        }

[nrc]

Wrong repo

[pnkfelix]

@nick29581 shouldn't you reopen the original issue in rust repo (or o/w address root problem) before closing these?

[nrc]

I did, then I moved them to libnum, then I closed them again.

[pnkfelix]

@nick29581 oh I see. The script was still saying RFC repo in its comment so I overlooked the fact that it now opened an issue on rust repo

[nrc]

AH, I forgot to change that part of the script :-( At least the link it right.

[pnkfelix]

(for those who didn't follow the ping-pong discussion: the ticket has moved to: rust-num/num#12 ;) )