Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Don't touch file system if the first change is AddFile #1330

Open
Xanewok opened this issue Feb 25, 2019 · 0 comments
Open

Don't touch file system if the first change is AddFile #1330

Xanewok opened this issue Feb 25, 2019 · 0 comments
Labels
enhancement Indicates new feature requests package: rls-vfs

Comments

@Xanewok
Copy link
Member

Xanewok commented Feb 25, 2019

Originally created by @matklad (rust-dev-tools/rls-vfs#11):

When the first change to a file is AddFile we could avoid touching the disk for better performance.

If the first change is not AddFile, we might want to log a warning, because we can't 100% guarantee consistency then. Though, this is unlikely to cause major problems in practice.

@Xanewok Xanewok added package: rls-vfs enhancement Indicates new feature requests labels Feb 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Indicates new feature requests package: rls-vfs
Projects
None yet
Development

No branches or pull requests

1 participant