Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

rustfmt_path invokes rustfmt with --file-lines [] #1463

Closed
jsgf opened this issue May 20, 2019 · 2 comments · Fixed by #1497
Closed

rustfmt_path invokes rustfmt with --file-lines [] #1463

jsgf opened this issue May 20, 2019 · 2 comments · Fixed by #1497

Comments

@jsgf
Copy link

jsgf commented May 20, 2019

If its trying to do a full-file reformat, the file_lines vector is empty. When it constructs the command line, it ends up emitting --file-lines [], which reformats nothing.

cc @Xanewok @ljw1004

@norru
Copy link

norru commented May 21, 2019

Is it related to #1397?

@jsgf
Copy link
Author

jsgf commented May 21, 2019

I think this only applies if you're using the rustfmt_path option - ie, using an external rustfmt binary rather than the library one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants