Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

VFS should use a rope rather than strings #21

Closed
nrc opened this issue Sep 29, 2016 · 2 comments
Closed

VFS should use a rope rather than strings #21

nrc opened this issue Sep 29, 2016 · 2 comments

Comments

@nrc
Copy link
Member

nrc commented Sep 29, 2016

No description provided.

@nrc
Copy link
Member Author

nrc commented Oct 30, 2017

@nrc nrc closed this as completed Oct 30, 2017
@ngortheone
Copy link

@nrc
I word of caution. I use xi-rope in my project and while most of the things are great there are downsides too. As an example unbounded searches in a rope are not cheap. See more details here:
xi-editor/xi-editor#1192

It may be possible to mitigate some of those, but specifically multilne regex searches are tough:

@cmyr
Doing multi-line regex efficiently would require a regex engine with a cursor API, which I don't see happening soon. :(

I don't want sound discouraging. Do your research and perf-testing before you do the switch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants