Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

VS Code mouseover tooltip links are broken #452

Closed
adyomin opened this issue Aug 21, 2017 · 4 comments
Closed

VS Code mouseover tooltip links are broken #452

adyomin opened this issue Aug 21, 2017 · 4 comments
Labels

Comments

@adyomin
Copy link

adyomin commented Aug 21, 2017

2017-08-21_20-24-11
I noticed that mouseover tooltips for std functions or other pieces of highlighted std code are broken. For example, for std::env::args() I get https://doc.rust-lang.org/nightly/std/env.t.html#args.v instead of https://doc.rust-lang.org/nightly/std/env/fn.args.html.

I like the feature a lot as I have just started learning the language. Is this something I can/should fix locally? Is it RLS related at all?

Edit: just in case added a screenshot of the "problem".

@nrc nrc added the bug label Aug 21, 2017
@nrc
Copy link
Member

nrc commented Aug 21, 2017

This is a bug somewhere in the RLS, I'm not exactly sure where. It's not quite as bad as it looks - there are redirects in rustdoc for the URLs we ought to be using, but we are still doing it a bit wrong. In this example, the desired URL is https://doc.rust-lang.org/nightly/std/env/args.v.html

@nrc
Copy link
Member

nrc commented Aug 21, 2017

I think the bug is in rls_analysis, but it might be in the compiler.

@nrc
Copy link
Member

nrc commented Sep 11, 2017

rust-dev-tools/rls-analysis#85 should mostly fix this, however, there are still some problems outstanding (I think mostly bugs in the Rustdoc redirects?). See that PR for details.

@nrc
Copy link
Member

nrc commented Jun 21, 2018

Fixed.

@nrc nrc closed this as completed Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants