Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit-returning macros in statement position should be completed with a semicolon #10913

Open
matklad opened this issue Dec 3, 2021 · 1 comment
Labels
A-completion autocompletion C-feature Category: feature request S-actionable Someone could pick this issue up and work on it right now

Comments

@matklad
Copy link
Member

matklad commented Dec 3, 2021

When completing assert, assert_eq, println and friends in statement context, we should insert ; automatically.

@lnicola lnicola added A-completion autocompletion C-bug Category: bug S-actionable Someone could pick this issue up and work on it right now labels Dec 3, 2021
@jhgg
Copy link
Contributor

jhgg commented Dec 6, 2021

Is there a good way to programmatically detect this, or should we just hard code a list of known macros?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-completion autocompletion C-feature Category: feature request S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Development

No branches or pull requests

4 participants