-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Implement hint dynamic unfolding #11702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I find this feature very interesting! I would like to take the time to explore its implementation. Currently, |
The main challenge is that the server cannot control when the client refreshes the inlay hints. As a result, we may need to add a state to server to track the expanded status of the hints, which could complicate the server. |
This sounds more like logic that the client should contain, not the server. So I don't think this is workable from our side |
It's indeed more suitable for the client to implement. Currently, VS Code truncates hints that exceed a certain length. A better solution would be to selectively collapse deeper hints based on their labels. However, the client needs to understand the structure of these labels to do this... |
The client has that information, the lsp encodes inlay hint parts already. To me this really sounds more like a feature request for editors (that is VSCode, Zed, etc) |
I actually agree now with the "it should be done in the editor" sentiment in the current days, hence closing. |
How about adding a tooltip to |
That we can do on the server yes |
Uh oh!
There was an error while loading. Please reload this page.
Depending on the user settings, rust-analyzer server can fold too long hints, i.e.
HashMap<String, Vec<...>>
.Now, when the VSCode client hints consist of ranges and support dynamic actions, we can make those folded hints dynamic and unfold them on click, similarly how Intellij does this now.
The text was updated successfully, but these errors were encountered: