Jumping to method with tracing::instrument macro fails

[gcohara]

With the following example

use tracing;

fn main() {
    println!("Hello, world!");
    Foo::bar()
}

struct Foo {}

impl Foo {
    #[tracing::instrument]
    fn bar() {}
}

attempting to jump to the definition of bar using M-. in Emacs fails with No definitions found for: bar.

However, with the attribute macro removed:

use tracing;

fn main() {
    println!("Hello, world!");
    Foo::bar()
}

struct Foo {}

impl Foo {
    fn bar() {}
}

this jumps successfully to bar.

rust-analyzer version: 2022-05-02, installed via HomeBrew

rustc version: 1.58.1

Please let me know if any further information would be useful for debugging.

[lnicola]

This works for me. Does lsp-mode enable proc macro attribute support?

It does: https://emacs-lsp.github.io/lsp-mode/page/lsp-rust-analyzer/#lsp-rust-analyzer-experimental-proc-attr-macros.

[lnicola]

CC @flodiebold ^

[Veykril]

This might be #12050 Actually no it shouldnt be

[gcohara]

Here are some relevant sections from the LSP mode logs:

Failing with the attribute macro

[Trace - 02:42:18 PM] Sending request 'textDocument/definition - (1423)'.
Params: {
  "textDocument": {
    "uri": "file:///Users/stuff/ra_test/src/main.rs"
  },
  "position": {
    "line": 4,
    "character": 9
  }
}


[Trace - 02:42:18 PM] Received response 'textDocument/definition - (1423)' in 0ms.
Result: []

Succeeding without the attribute macro:

Params: {
  "textDocument": {
    "uri": "file:///Users/stuff/ra_test/src/main.rs"
  },
  "position": {
    "line": 4,
    "character": 10
  }
}


[Trace - 02:43:23 PM] Received response 'textDocument/definition - (1438)' in 0ms.
Result: [
  {
    "targetSelectionRange": {
      "end": {
        "character": 10,
        "line": 11
      },
      "start": {
        "character": 7,
        "line": 11
      }
    },
    "targetRange": {
      "end": {
        "character": 15,
        "line": 11
      },
      "start": {
        "character": 4,
        "line": 10
      }
    },
    "targetUri": "file:///Users/stuff/ra_test/src/main.rs",
    "originSelectionRange": {
      "end": {
        "character": 12,
        "line": 4
      },
      "start": {
        "character": 9,
        "line": 4
      }
    }
  }
]```

[lnicola]

Do you have any relevant LSP config? Is lsp-mode up to date?

[gcohara]

I'm on LSP mode 8.0.0 which is the most recent. I don't have any LSP mode stuff in my init.el that I think could be relevant.

(setq lsp-ui-sideline-show-hover nil)
(setq lsp-ui-sideline-show-code-actions nil)
(setq lsp-ui-doc-enable nil)
(setq lsp-ui-sideline-enable nil)
(setq lsp-ui-doc-show-with-mouse nil)
(setq lsp-diagnostics-provider :flymake)
(setq lsp-signature-render-documentation nil)
(setq lsp-signature-auto-activate nil)

is about it.

I checked the variable you mentioned - it was set to nil. I tried setting it to t but this didn't help sadly.

[lnicola]

You might have to restart RA/LSP/emacs. Don't set it to nil.

[flodiebold]

If it was just a matter of proc macro expansion being disabled, go to definition would still work, wouldn't it? It might be the expansion failing instead for some reason? 🤔

[gcohara]

Restarted Emacs and RA with lsp-rust-analyzer-experimental-proc-attr-macros set to t but still no luck

[Veykril]

Can't repro this either in my VSCode. I assume you are using the latest tracing version? As flodiebold said, a disabled expansion shouldn't cause that. So the expansion is most likely failing in some way. Are there any errors in your logs?

[gcohara]

It turns out that lsp-rust-analyzer-proc-macro-enable was set to nil. Setting it to t solved it!

Apologies for wasting your time, and many thanks to all of you for being so helpful.