Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type completions in tuple structs/variants are broken by attributes #12259

Closed
jonas-schievink opened this issue May 15, 2022 · 3 comments · Fixed by #12360
Closed

Type completions in tuple structs/variants are broken by attributes #12259

jonas-schievink opened this issue May 15, 2022 · 3 comments · Fixed by #12360
Labels
A-completion autocompletion C-bug Category: bug S-actionable Someone could pick this issue up and work on it right now

Comments

@jonas-schievink
Copy link
Contributor

struct Newtype(#[serde] Old$0);

struct Oldtype;

This does not complete Oldtype (or anything else).

@jonas-schievink jonas-schievink added A-completion autocompletion S-actionable Someone could pick this issue up and work on it right now C-bug Category: bug labels May 15, 2022
@yue4u
Copy link
Contributor

yue4u commented May 23, 2022

I dug into this a bit and found it was disabled intentionally at 11115eb in #9301. Since is_path_disallowed been marked as "shouldn't exist" in 25d133e#diff-563c0914dd89f1c5e6ca3ae5eb22105f0bcd42c15ae26580a4e7a25dc10d9a96R296 I guess this issue will be resolved as a part of #12144?

@Veykril
Copy link
Member

Veykril commented May 23, 2022

I just looked into this as well 😅, and yes that is the problem. We can actually remove that attribute rule from is_path_disallowed as our completions seem to be good enough to already handle the unwanted cases covered by it.

@Veykril
Copy link
Member

Veykril commented May 23, 2022

I'll add the functions that shouldn't exist to that tracking issue as tasks actually.

@bors bors closed this as completed in 402dba8 May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-completion autocompletion C-bug Category: bug S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants