Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSCode: Show error when go-to-definition fails because of cyclic dependencies #12407

Closed
justinmoon opened this issue May 28, 2022 · 2 comments
Closed

VSCode: Show error when go-to-definition fails because of cyclic dependencies #12407

justinmoon opened this issue May 28, 2022 · 2 comments
Labels
C-feature Category: feature request S-unactionable Issue requires feedback, design decisions or is blocked on other work

Comments

@justinmoon
Copy link

justinmoon commented May 28, 2022 •
edited
Loading

"Go-to-definition" wasn't working for a specific crate in my project. After spending a good while investigating I figured out it was because of circular dependencies:

$ rust-analyzer analysis-stats .
[ERROR project_model::workspace] cyclic deps: minimint(CrateId(171)) -> ln_gateway(CrateId(159)), alternative path: ln_gateway(CrateId(159)) -> minimint(CrateId(171))
[ERROR project_model::workspace] cyclic deps: mint_client(CrateId(183)) -> minimint(CrateId(171)), alternative path: minimint(CrateId(171)) -> mint_client(CrateId(183))

I understand from Zulip this is a known limitation of rust-analyzer (#11410). It would be very nice if the VSCode extension could explain this is the problem when go-to-definition fails, instead unhelpful "No definition found for X" message. I'm using v0.3.1066 of the plugin if that helps ...
@justinmoon justinmoon mentioned this issue May 29, 2022
Closed
@jonas-schievink
Copy link
Contributor

It would probably be easier to just fix the limitation

@flodiebold flodiebold added S-unactionable Issue requires feedback, design decisions or is blocked on other work C-feature Category: feature request labels Jun 17, 2022
@Veykril Veykril mentioned this issue Feb 16, 2023
Open
@Veykril
Copy link
Member

Veykril commented Feb 16, 2023

Closing in favor of #14167

@Veykril Veykril closed this as completed Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature Category: feature request S-unactionable Issue requires feedback, design decisions or is blocked on other work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@flodiebold @jonas-schievink @Veykril @justinmoon