Skip to content

npm run fix does not format everything #2515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lnicola opened this issue Dec 9, 2019 · 0 comments · Fixed by #2583
Closed

npm run fix does not format everything #2515

lnicola opened this issue Dec 9, 2019 · 0 comments · Fixed by #2583

Comments

@lnicola
Copy link
Member

lnicola commented Dec 9, 2019

Not sure what's happening here:

$ npm run fix

> ra-lsp@0.0.1 fix ~/Projects/rust-analyzer/editors/code
> prettier **/*.{json,ts} --write && tslint --project . --fix

.vscode/launch.json 27ms
.vscode/settings.json 5ms
.vscode/tasks.json 4ms
package-lock.json 88ms
package.json 21ms
src/test/fixtures/rust-diagnostics/clippy/trivially_copy_pass_by_ref.json 13ms
src/test/fixtures/rust-diagnostics/error/E0053.json 8ms
src/test/fixtures/rust-diagnostics/error/E0061.json 16ms
src/test/fixtures/rust-diagnostics/error/E0308.json 6ms
src/test/fixtures/rust-diagnostics/warning/unused_variables.json 7ms
tsconfig.json 3ms
tslint.json 3ms
src/config.ts 167ms
src/extension.ts 65ms
src/highlighting.ts 45ms
src/server.ts 37ms

$ prettier **/*.{json,ts} --write
package.json 46ms
package-lock.json 75ms
src/test/fixtures/rust-diagnostics/clippy/trivially_copy_pass_by_ref.json 21ms
src/test/fixtures/rust-diagnostics/error/E0053.json 7ms
src/test/fixtures/rust-diagnostics/error/E0061.json 16ms
src/test/fixtures/rust-diagnostics/error/E0308.json 5ms
src/test/fixtures/rust-diagnostics/warning/unused_variables.json 12ms
tsconfig.json 5ms
tslint.json 7ms
src/commands/analyzer_status.ts 144ms
src/commands/apply_source_change.ts 19ms
src/commands/cargo_watch.ts 76ms
src/commands/expand_macro.ts 24ms
src/commands/index.ts 7ms
src/commands/inlay_hints.ts 29ms
src/commands/join_lines.ts 13ms
src/commands/line_buffer.ts 7ms
src/commands/matching_brace.ts 14ms
src/commands/on_enter.ts 12ms
src/commands/parent_module.ts 8ms
src/commands/runnables.ts 46ms
src/commands/syntaxTree.ts 18ms
src/commands/watch_status.ts 17ms
src/config.ts 35ms
src/events/change_active_text_editor.ts 10ms
src/events/change_text_document.ts 5ms
src/events/index.ts 3ms
src/extension.ts 28ms
src/highlighting.ts 25ms
src/notifications/index.ts 3ms
src/notifications/publish_decorations.ts 3ms
src/server.ts 11ms
src/test/runTest.ts 7ms
src/test/utils/diagnotics/rust.test.ts 18ms
src/test/utils/diagnotics/SuggestedFixCollection.test.ts 15ms
src/test/utils/diagnotics/SuggestedFix.test.ts 13ms
src/test/utils/diagnotics/vscode.test.ts 14ms
src/test/utils/index.ts 6ms
src/utils/diagnostics/rust.ts 30ms
src/utils/diagnostics/SuggestedFixCollection.ts 12ms
src/utils/diagnostics/SuggestedFix.ts 7ms
src/utils/diagnostics/vscode.ts 3ms
src/utils/processes.ts 6ms
$ prettier -v    
1.19.1
$ npm run prettier -- -v

> ra-lsp@0.0.1 prettier ~/Projects/rust-analyzer/editors/code
> prettier **/*.{json,ts} "-v"

1.19.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant