Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging infrastructure to TypeScript VSCode extension #3250

Closed
Veetaha opened this issue Feb 20, 2020 · 0 comments
Closed

Add logging infrastructure to TypeScript VSCode extension #3250

Veetaha opened this issue Feb 20, 2020 · 0 comments

Comments

@Veetaha
Copy link
Contributor

Veetaha commented Feb 20, 2020

Rationale

In our VSCode extension we use simple console.log() and console.error() functions to print debugging-related stuff. It does help a lot, but it has quite a few big flaws.

Proposal

At the end of they day we need to record logs in files (put them in ExtensionHost.logPath)

The initial proposal for the infrastructure was stated by @matklad in this comment.

We currently haven't agreed on the exact design of logging. So this is need to be done yet.

Just a quick-and-not-yet-ultimate thought from me: I'd like to propose some logger package like
pino.

If anybody has some design proposal, it would be great to hear from you! Anyway, once I have time, I'll take it to investigate what we can do here and post my thoughts here so we can agree on the final shape of our logging infra.

References

@Veetaha Veetaha changed the title Add proper log handling infrastructure to VSCode extension Add log handling infrastructure to VSCode extension Feb 20, 2020
@Veetaha Veetaha changed the title Add log handling infrastructure to VSCode extension Add logging infrastructure to VSCode extension Feb 20, 2020
@Veetaha Veetaha changed the title Add logging infrastructure to VSCode extension Add logging infrastructure to TypeScript VSCode extension Feb 20, 2020
@matklad matklad closed this as completed Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants