Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlay hints confuse matching bracket highligher #3453

Closed
0x7CFE opened this issue Mar 4, 2020 · 3 comments
Closed

Inlay hints confuse matching bracket highligher #3453

0x7CFE opened this issue Mar 4, 2020 · 3 comments
Labels
A-inlay-hints inlay/inline hints A-vscode vscode plugin issues S-unactionable Issue requires feedback, design decisions or is blocked on other work

Comments

@0x7CFE
Copy link

0x7CFE commented Mar 4, 2020

tldr:
wasmtime-1583336971580

Also note that its currently impossible to put the cursor right after (, for example, to add another parameter before current one. If it's not related to this issue then I'd file another one specifically for cursor movement.

Revision 66ec6bd.

@flodiebold flodiebold added the A-vscode vscode plugin issues label Mar 4, 2020
@SomeoneToIgnore
Copy link
Contributor

This is a limitation we have due to the hints being implemented via VSCode decorations.

Before your issue, we had a number of reports (for example #1623) about the weird caret positioning, but this is the first about the highlighting.

Is it true that the Match Brackets setting and functionality is something that VS Code implements and provides?

If so, we should report the highlighting issue to their repo.
As for the caret position and improving inlay hints in general, here's the proper (long and demanding) way to do this: #2797

I've created a PR to update the docs describing the limitations: #3468

@bjorn3
Copy link
Member

bjorn3 commented Mar 5, 2020

but this is the first about the highlighting.

I noticed this too, but didn't consider this important enough to create an issue.

@lnicola lnicola added the S-unactionable Issue requires feedback, design decisions or is blocked on other work label Jan 22, 2021
@Veykril Veykril added the A-inlay-hints inlay/inline hints label Dec 17, 2021
@Veykril
Copy link
Member

Veykril commented Mar 16, 2022

Works fine with the native inlay hints now

@Veykril Veykril closed this as completed Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-inlay-hints inlay/inline hints A-vscode vscode plugin issues S-unactionable Issue requires feedback, design decisions or is blocked on other work
Projects
None yet
Development

No branches or pull requests

6 participants