Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-analyzer.files.exclude does not appear to work. #7710

Closed
jlennox opened this issue Feb 17, 2021 · 3 comments
Closed

rust-analyzer.files.exclude does not appear to work. #7710

jlennox opened this issue Feb 17, 2021 · 3 comments
Labels
A-vscode vscode plugin issues S-unactionable Issue requires feedback, design decisions or is blocked on other work

Comments

@jlennox
Copy link

jlennox commented Feb 17, 2021

VS Code plugin version: 0.2.384
Operating system: macOS

  "rust-analyzer.files.exclude": [
    "depot_tools",
    "depot_tools/**",
    "**/depot_tools/**",
  ],

With the above setting, when I run lsof -p ... against the pid of rust-analyzer-mac, I still see:

COMMAND     PID USER   FD   TYPE             DEVICE SIZE/OFF                NODE NAME
rust-anal 11611 joe   cwd    DIR                1,5     5024             1179243 /Users/joe/unnamed
rust-anal 11611 joe   txt    REG                1,5 26238796             8150686 /Users/joe/.vscode-server/data/User/globalStorage/matklad.rust-analyzer/rust-analyzer-mac
rust-anal 11611 joe   txt    REG                1,5    28512            58261595 /Library/Preferences/Logging/.plist-cache.3Q4Ym2GG
rust-anal 11611 joe   txt    REG                1,5  1566832 1152921500312850218 /usr/lib/dyld
rust-anal 11611 joe     0u  unix 0x63b6800553858757      0t0                     ->0x63b6800553856bff
rust-anal 11611 joe     1u  unix 0x63b6800553858437      0t0                     ->0x63b68005538588e7
rust-anal 11611 joe     2u  unix 0x63b680055385723f      0t0                     ->0x63b6800553858a77
rust-anal 11611 joe     3r   DIR                1,5     2464             1208848 /Users/joe/unnamed/tools
rust-anal 11611 joe     4r   DIR                1,5     6848             2474592 /Users/joe/unnamed/tools/depot_tools
rust-anal 11611 joe     5r   DIR                1,5       96            35660039 /Users/joe/unnamed/tools/depot_tools/external_bin
rust-anal 11611 joe     6r   DIR                1,5       96            35660040 /Users/joe/unnamed/tools/depot_tools/external_bin/gsutil
rust-anal 11611 joe     7r   DIR                1,5       96            35660043 /Users/joe/unnamed/tools/depot_tools/external_bin/gsutil/gsutil_4.28
rust-anal 11611 joe     8r   DIR                1,5      512            35660044 /Users/joe/unnamed/tools/depot_tools/external_bin/gsutil/gsutil_4.28/gsutil
rust-anal 11611 joe     9r   DIR                1,5     1952            35661878 /Users/joe/unnamed/tools/depot_tools/external_bin/gsutil/gsutil_4.28/gsutil/gslib
rust-anal 11611 joe    10r   DIR                1,5      160            35661893 /Users/joe/unnamed/tools/depot_tools/external_bin/gsutil/gsutil_4.28/gsutil/gslib/third_party
rust-anal 11611 joe    11r   DIR                1,5      192            35661898 /Users/joe/unnamed/tools/depot_tools/external_bin/gsutil/gsutil_4.28/gsutil/gslib/third_party/storage_apitools

I have the problem that my repository contains a large amount of directories and I really need many of them to be skipped, otherwise rust-analyzer's package scan takes multiple hours to complete.

I found this setting has gone through an unfortunate identity crisis. rust-analyzer.excludeGlobs to rust-analyzer.files.exclude to rust-analyzer.files.excludeDirs inside of a year. I'm using what appears to be defined inside of my packages.json.

@lnicola
Copy link
Member

lnicola commented Feb 20, 2021

It looks like this is called rust-analyzer.files.excludeDirs since #7451.

Anyway, the latest extension version is 0.2.489 and at one release every week, 0.2.384 is 105 weeks old.

EDIT: sorry, I guess the extension version might get bumped by 7 every week, which would make yours only 105 days old.

@lnicola lnicola added A-vscode vscode plugin issues S-unactionable Issue requires feedback, design decisions or is blocked on other work labels Feb 20, 2021
@jlennox
Copy link
Author

jlennox commented Feb 24, 2021

Thank you. It appears my dated VSCode was keeping me on an old version and updating it added rust-analyzer.files.excludeDirs which appears to work.

@jlennox jlennox closed this as completed Feb 24, 2021
@lnicola
Copy link
Member

lnicola commented Feb 24, 2021

You might still want to keep an eye on #7755, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-vscode vscode plugin issues S-unactionable Issue requires feedback, design decisions or is blocked on other work
Projects
None yet
Development

No branches or pull requests

2 participants