Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integrated completion benchmark #8517

Closed
matklad opened this issue Apr 14, 2021 · 3 comments
Closed

Add integrated completion benchmark #8517

matklad opened this issue Apr 14, 2021 · 3 comments
Assignees
@matklad
Labels
Broken Window Bugs / technical debt to be addressed immediately

Comments

@matklad
Copy link
Member

matklad commented Apr 14, 2021

Like https://github.com/rust-analyzer/rust-analyzer/blob/e6728a8cd39f9111dcdd654c7c65e99e5a2f1190/crates/rust-analyzer/src/benchmarks.rs#L22

cc #8515 (comment)
@matklad matklad added the Broken Window Bugs / technical debt to be addressed immediately label Apr 14, 2021
@SomeoneToIgnore
Copy link
Contributor

Duplicate of #6633 ?

@matklad
Copy link
Member Author

matklad commented Apr 14, 2021

Not really. Simple integrated benchmark is a broken window, but I'd love to see something fancier with generated code for #6633

@matklad matklad assigned matklad and unassigned SomeoneToIgnore May 4, 2021
@lnicola
Copy link
Member

lnicola commented May 5, 2021

I guess we can close this now?

@matklad matklad closed this as completed May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matklad matklad

Labels
Broken Window Bugs / technical debt to be addressed immediately
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lnicola @matklad @SomeoneToIgnore