Skip to content

0.53.0 broke semver? #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dvdplm opened this issue May 5, 2020 · 3 comments
Closed

0.53.0 broke semver? #1776

dvdplm opened this issue May 5, 2020 · 3 comments

Comments

@dvdplm
Copy link

dvdplm commented May 5, 2020

I think #1688 broke semver. Updating rust-mbedtls from using bindgen@0.52.0to ``bindgen@0.53.0` I'm getting a ton of errors like:

error[E0308]: mismatched types
   --> mbedtls/src/x509/csr.rs:196:22
    |
196 |                 Some(F::call),
    |                      ^^^^^^^ expected `u64`, found `usize`
    |
    = note: expected fn pointer `unsafe extern "C" fn(_, _, u64) -> _`
                  found fn item `unsafe extern "C" fn(_, _, usize) -> _ {<F as rng::RngCallback>::call}`

Possibly the culprit is #1688?

Not sure what can be done at this time, but yeah, upgrading bindgen is harder than it could be.

@LunaBorowska
Copy link

It didn't. See https://semver.org/.

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

@emilio
Copy link
Contributor

emilio commented May 8, 2020

Yes, plus fwiw, you may want size_t_is_usize=true to restore the previous behavior.

@emilio emilio closed this as completed May 8, 2020
@dvdplm
Copy link
Author

dvdplm commented May 8, 2020

Yes, plus fwiw, you may want size_t_is_usize=true to restore the previous behavior.

Right, which was introduced in 0.53.0 if I’m not mistaken?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants