Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Builder::whitelist/blacklist? #1961

Closed
saschanaz opened this issue Dec 31, 2020 · 1 comment
Closed

Rename Builder::whitelist/blacklist? #1961

saschanaz opened this issue Dec 31, 2020 · 1 comment

Comments

@saschanaz
Copy link

Builder has several uses of the words e.g. blacklist_type, could they be deprecated and replaced with better words?
@kulp
Copy link
Member

kulp commented Dec 31, 2020

This seems to be a duplicate of #1812. Feel free to continue discussion there if you think there is something new to add.

@kulp kulp closed this as completed Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kulp @saschanaz