Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better diff display for failing tests #2541

Closed
pvdrz opened this issue May 30, 2023 · 0 comments · Fixed by #2577
Closed

Better diff display for failing tests #2541

pvdrz opened this issue May 30, 2023 · 0 comments · Fixed by #2577

Comments

@pvdrz
Copy link
Contributor

pvdrz commented May 30, 2023

Right now bindgen prints the complete expectation file if a test fails but most of the time the diff only involves a couple lines. Maybe using a crate like similar to print the diffs would help.

Relevant code:

rust-bindgen/bindgen-tests/tests/tests.rs

Line 43 in a710e50

fn error_diff_mismatch(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make expected-tests diff more pretty tshepang/rust-bindgen
1 participant
@pvdrz