Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether to transition all examples from make test to cargo test #439

Closed
mdinger opened this issue Jan 30, 2015 · 6 comments
Closed

Comments

@mdinger
Copy link
Contributor

mdinger commented Jan 30, 2015

All the examples could be transitioned to cargo test from make test as discussed on PR #433 (comment) . Currently this would be awkward without toml-lang/toml#235 and so we're waiting for that to materialize before a decision is made for or against transitioning.

@steveklabnik I'm assuming postponing this is fine for now. If so, can you flag this postponed?

@steveklabnik
Copy link
Member

yes, I want everyone to go to cargo test, but haven't had the time to do
the work. I personally don't care if the compact toml syntax lands or not.

@steveklabnik
Copy link
Member

(there is no postponed tag)

@mdinger
Copy link
Contributor Author

mdinger commented Jan 30, 2015

Okay. That's helpful because previously I'd be hesitant to start porting because I wasn't sure if it'd be accepted.

I want the syntax so I doubt I'll work on porting it until then but someone else is welcome to it if they want

@mdinger
Copy link
Contributor Author

mdinger commented Feb 5, 2015

rust-lang/cargo#1225 is wip to provide dependency access for cargo. If this supports export to JSON, it could potentially allow a direct migration without many changes aside from the Cargo.toml and the structure file.

@steveklabnik
Copy link
Member

The changes to toml have landed.

@steveklabnik
Copy link
Member

This is now mdbook test 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants