|
| 1 | +use clippy_utils::consts::{constant, Constant}; |
| 2 | +use clippy_utils::diagnostics::span_lint_and_then; |
| 3 | +use clippy_utils::higher::VecArgs; |
| 4 | +use clippy_utils::macros::root_macro_call; |
| 5 | +use clippy_utils::source::snippet; |
| 6 | +use clippy_utils::{expr_or_init, fn_def_id, match_def_path, paths}; |
| 7 | +use rustc_errors::Applicability; |
| 8 | +use rustc_hir::{Expr, ExprKind}; |
| 9 | +use rustc_lint::{LateContext, LateLintPass}; |
| 10 | +use rustc_session::{declare_lint_pass, declare_tool_lint}; |
| 11 | +use rustc_span::{sym, Span}; |
| 12 | + |
| 13 | +declare_clippy_lint! { |
| 14 | + /// ### What it does |
| 15 | + /// Looks for patterns such as `vec![Vec::with_capacity(x); n]` or `iter::repeat(Vec::with_capacity(x))`. |
| 16 | + /// |
| 17 | + /// ### Why is this bad? |
| 18 | + /// These constructs work by cloning the element, but cloning a `Vec<_>` does not |
| 19 | + /// respect the old vector's capacity and effectively discards it. |
| 20 | + /// |
| 21 | + /// This makes `iter::repeat(Vec::with_capacity(x))` especially suspicious because the user most certainly |
| 22 | + /// expected that the yielded `Vec<_>` will have the requested capacity, otherwise one can simply write |
| 23 | + /// `iter::repeat(Vec::new())` instead and it will have the same effect. |
| 24 | + /// |
| 25 | + /// Similarily for `vec![x; n]`, the element `x` is cloned to fill the vec. |
| 26 | + /// Unlike `iter::repeat` however, the vec repeat macro does not have to clone the value `n` times |
| 27 | + /// but just `n - 1` times, because it can reuse the passed value for the last slot. |
| 28 | + /// That means that the last `Vec<_>` gets the requested capacity but all other ones do not. |
| 29 | + /// |
| 30 | + /// ### Example |
| 31 | + /// ```rust |
| 32 | + /// let _: Vec<Vec<u8>> = vec![Vec::with_capacity(42); 123]; |
| 33 | + /// ``` |
| 34 | + /// Use instead: |
| 35 | + /// ```rust |
| 36 | + /// let _: Vec<Vec<u8>> = (0..123).map(|_| Vec::with_capacity(42)).collect(); |
| 37 | + /// // ^^^ this closure executes 123 times |
| 38 | + /// // and the vecs will have the expected capacity |
| 39 | + /// ``` |
| 40 | + #[clippy::version = "1.74.0"] |
| 41 | + pub REPEAT_VEC_WITH_CAPACITY, |
| 42 | + suspicious, |
| 43 | + "repeating a `Vec::with_capacity` expression which does not retain capacity" |
| 44 | +} |
| 45 | + |
| 46 | +declare_lint_pass!(RepeatVecWithCapacity => [REPEAT_VEC_WITH_CAPACITY]); |
| 47 | + |
| 48 | +fn emit_lint(cx: &LateContext<'_>, span: Span, kind: &str, note: &'static str, sugg_msg: &'static str, sugg: String) { |
| 49 | + span_lint_and_then( |
| 50 | + cx, |
| 51 | + REPEAT_VEC_WITH_CAPACITY, |
| 52 | + span, |
| 53 | + &format!("repeating `Vec::with_capacity` using `{kind}`, which does not retain capacity"), |
| 54 | + |diag| { |
| 55 | + diag.note(note); |
| 56 | + diag.span_suggestion_verbose(span, sugg_msg, sugg, Applicability::MaybeIncorrect); |
| 57 | + }, |
| 58 | + ); |
| 59 | +} |
| 60 | + |
| 61 | +/// Checks `vec![Vec::with_capacity(x); n]` |
| 62 | +fn check_vec_macro(cx: &LateContext<'_>, expr: &Expr<'_>) { |
| 63 | + if let Some(mac_call) = root_macro_call(expr.span) |
| 64 | + && cx.tcx.is_diagnostic_item(sym::vec_macro, mac_call.def_id) |
| 65 | + && let Some(VecArgs::Repeat(repeat_expr, len_expr)) = VecArgs::hir(cx, expr) |
| 66 | + && fn_def_id(cx, repeat_expr).is_some_and(|did| match_def_path(cx, did, &paths::VEC_WITH_CAPACITY)) |
| 67 | + && !len_expr.span.from_expansion() |
| 68 | + && let Some(Constant::Int(2..)) = constant(cx, cx.typeck_results(), expr_or_init(cx, len_expr)) |
| 69 | + { |
| 70 | + emit_lint( |
| 71 | + cx, |
| 72 | + expr.span.source_callsite(), |
| 73 | + "vec![x; n]", |
| 74 | + "only the last `Vec` will have the capacity", |
| 75 | + "if you intended to initialize multiple `Vec`s with an initial capacity, try", |
| 76 | + format!( |
| 77 | + "(0..{}).map(|_| {}).collect::<Vec<_>>()", |
| 78 | + snippet(cx, len_expr.span, ""), |
| 79 | + snippet(cx, repeat_expr.span, "..") |
| 80 | + ), |
| 81 | + ); |
| 82 | + } |
| 83 | +} |
| 84 | + |
| 85 | +/// Checks `iter::repeat(Vec::with_capacity(x))` |
| 86 | +fn check_repeat_fn(cx: &LateContext<'_>, expr: &Expr<'_>) { |
| 87 | + if !expr.span.from_expansion() |
| 88 | + && fn_def_id(cx, expr).is_some_and(|did| cx.tcx.is_diagnostic_item(sym::iter_repeat, did)) |
| 89 | + && let ExprKind::Call(_, [repeat_expr]) = expr.kind |
| 90 | + && fn_def_id(cx, repeat_expr).is_some_and(|did| match_def_path(cx, did, &paths::VEC_WITH_CAPACITY)) |
| 91 | + && !repeat_expr.span.from_expansion() |
| 92 | + { |
| 93 | + emit_lint( |
| 94 | + cx, |
| 95 | + expr.span, |
| 96 | + "iter::repeat", |
| 97 | + "none of the yielded `Vec`s will have the requested capacity", |
| 98 | + "if you intended to create an iterator that yields `Vec`s with an initial capacity, try", |
| 99 | + format!("std::iter::from_fn(|| Some({}))", snippet(cx, repeat_expr.span, "..")), |
| 100 | + ); |
| 101 | + } |
| 102 | +} |
| 103 | + |
| 104 | +impl LateLintPass<'_> for RepeatVecWithCapacity { |
| 105 | + fn check_expr(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) { |
| 106 | + check_vec_macro(cx, expr); |
| 107 | + check_repeat_fn(cx, expr); |
| 108 | + } |
| 109 | +} |
0 commit comments