WIP: How to detect hidden attribute?

Author: phansch

clippy_lints/src/attrs.rs

@@ -7,7 +7,6 @@ use rustc::ty::{self, TyCtxt};
 use semver::Version;
 use syntax::ast::{Attribute, AttrStyle, Lit, LitKind, MetaItemKind, NestedMetaItem, NestedMetaItemKind};
 use syntax::codemap::Span;
-use syntax_pos::{Pos};
 use utils::{in_macro, match_def_path, opt_def_id, paths, snippet_opt, span_lint, span_lint_and_then};
 
 /// **What it does:** Checks for items annotated with `#[inline(always)]`,
@@ -268,7 +267,24 @@ fn check_attrs(cx: &LateContext, span: Span, name: &Name, attrs: &[Attribute]) {
 
             if let Some(snippet) = snippet_opt(cx, attr_to_item_span) {
                 let lines = snippet.split('\n').collect::<Vec<_>>();
-                if lines.iter().filter(|l| l.trim().is_empty()).count() > 1 && !is_hidden_attr(attr) {
+                if lines.iter().filter(|l| l.trim().is_empty()).count() > 1 {
+                    println!("attr.style {:?}", attr.style);
+                    println!("attr.name() {:?}", attr.name());
+                    println!("attr.meta() {:?}", attr.meta());
+                    println!("attr.value_str() {:?}", attr.value_str());
+                    println!("attr.is_sugared_doc {:?}", attr.is_sugared_doc);
+                    println!("attr.path {:?}", attr.path);
+                    println!("attr.span {:?}", attr.span);
+                    println!("attr.span.end_point() {:?}", attr.span.end_point());
+                    println!("attr.span.next_point() {:?}", attr.span.next_point());
+                    println!("attr.span.source_callsite() {:?}", attr.span.source_callsite());
+                    println!("attr.span.source_callee() {:?}", attr.span.source_callee());
+                    println!("attr.span.macro_backtrace() {:?}", attr.span.macro_backtrace());
+                    println!("attr.span.compiler_desugaring_kind() {:?}", attr.span.compiler_desugaring_kind());
+                    println!("attr.span.end_point().macro_backtrace() {:?}", attr.span.end_point().macro_backtrace());
+                    println!("attr.span.end_point().lo() {:?}", attr.span.end_point().lo());
+                    println!("attr.span.end_point().hi() {:?}", attr.span.end_point().hi());
+                    println!("whats between? {:?}", snippet_opt(cx, Span::new(attr.span.end_point().lo(), attr.span.end_point().hi(), attr.span.end_point().ctxt())));
                     span_lint(
                         cx,
                         EMPTY_LINE_AFTER_OUTER_ATTR,
@@ -313,10 +329,6 @@ fn check_semver(cx: &LateContext, span: Span, lit: &Lit) {
     );
 }
 
-fn is_hidden_attr(attr: &Attribute) -> bool {
-    attr.span.lo().to_usize() == 0 && attr.span.hi().to_usize() == 0
-}
-
 fn is_word(nmi: &NestedMetaItem, expected: &str) -> bool {
     if let NestedMetaItemKind::MetaItem(ref mi) = nmi.node {
         mi.is_word() && mi.name() == expected

tests/weird_hidden_attribute.rs

@@ -0,0 +1,6 @@
+#![feature(plugin)]
+#![plugin(clippy)]
+
+fn main() {
+    assert!(true);
+}