Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing std::str::* lints to also check inherent_str_constructors #14254

Closed
tgross35 opened this issue Feb 19, 2025 · 3 comments
Closed
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages good-first-issue These issues are a good way to get started with Clippy

Comments

@tgross35
Copy link
Contributor

tgross35 commented Feb 19, 2025

Description

A few clippy lints make use of the str_from_utf8* diagnostic items. Since recently, there is now a new set of diagnostic items str_inherent_from_utf8* associated with the inherent_str_constructors feature rust-lang/rust#131114, which should be checked in the same way.

See rust-lang/rust#137101 for the rustc update.

@tgross35
Copy link
Contributor Author

I think this should be pretty easy:

@rustbot label +good-first-issue +C-enhancement

@rustbot rustbot added C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages good-first-issue These issues are a good way to get started with Clippy labels Feb 19, 2025
@xizheyin
Copy link

When I search for str_from_utf8 in the code, I found the issue might have been solved. I found this commit.

@tgross35
Copy link
Contributor Author

Ah, I opened this too late then! Thanks for finding that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages good-first-issue These issues are a good way to get started with Clippy
Projects
None yet
Development

No branches or pull requests

3 participants