no mk_sp in codemap: compiling with latest rustc nightly fails

[atodorov]

I'm seeing lots of these errors:

 --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/clippy_lints-0.0.121/src/formatting.rs:2:5

  |

2 | use syntax::codemap::mk_sp;

  |     ^^^^^^^^^^^^^^^^^^^^^^ no `mk_sp` in `codemap`

Here's my Travis log:
https://travis-ci.org/atodorov/bdcs-api-rs/jobs/217103465

[oli-obk]

Yea, we need to rustup. Can someone please take this?

[polybuildr]

Is there a temporary workaround? If I use the previous version of rust nightly, would I be able to compile clippy?

[oli-obk]

Use the nightly from 2017-03-28

[mirandadam]

Looking at the history of src/libsyntax/codemap.rs, it seems commit rust-lang/rust@f08d5ad no longer publishes mk_sp.

I figure that syntax_pos::Span should be used instead. mk_sp is now used as below in in src/libsyntax/parse/lexer/mod.rs:

fn mk_sp(lo: BytePos, hi: BytePos) -> Span {
    Span { lo: lo, hi: hi, ctxt: NO_EXPANSION }
}

Will try to whip out a P.R. in a few minutes.

[oli-obk]

we have a PR partially fixing this. But we broke a lint, so I don't want to publish yet

[mirandadam]

Awesome! Thanks for the quick reply.

[oli-obk]

Clippy has been updated and published for the latest nightly.

Sorry about the long wait